internal/static: remove unreachable code #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While #15 removed static mode and operator from being reachable from the binary, all static mode code remained in the database to be removed later. This commit removes all unreachable code; what remains is constrained to config structre which is still used for config conversion. This commit does accidentally remove code that changed the order of static mode conversion components. This isn't a big deal, and the converted configs are still correct, so that code is being left out rather than being hunted down. (It is likely code that implements an interface but wasn't called directly.)
rfratto
changed the title
rfratto
changed the title
rfratto
added
the
backport-to-agent:no
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #15 removed static mode and operator from being reachable from the binary, all static mode code remained in the database to be removed later.
This commit removes all unreachable code; what remains is constrained to config structre which is still used for config conversion.
This commit does accidentally remove code that changed the order of static mode conversion components. This isn't a big deal, and the converted configs are still correct, so that code is being left out rather than being hunted down. (It is likely code that implements an interface but wasn't called directly.)
To verify the changed order of staticconvert tests doesn't matter, I ran the tests 30 times to confirm consistent results.