Update snmp doc #1919
Open
Update snmp doc #1919
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
reviewed
Oct 18, 2024
| @@ -48,7 +48,7 @@ Omitted fields take their default values. | |||
| | `targets` | `list(map(string))` | SNMP targets. | | no | | |||
|
|
|||
| The `config_file` argument points to a YAML file defining which snmp_exporter modules to use. | |||
| Refer to [snmp_exporter](https://github.com/prometheus/snmp_exporter#generating-configuration) for details on how to generate a configuration file. | |||
| Refer to [snmp_exporter](https://github.com/prometheus/snmp_exporter/tree/v0.26.0?tab=readme-ov-file#configuration) for details on how to generate a configuration file. | |||
There was a problem hiding this comment.
It might be best to add an SNMP_EXP_VERSION to docs/sources/_index.md.t, and to also use it in the link to the upsteram repo at the top of the page, as well as in the {{< admonition type="note" >}}
There was a problem hiding this comment.
thanks for the suggestion, that's much better indeed. I added a comment in the go.mod also for the windows exporter in case there is an update to also change the version. Btw it seems that it's already out of sync, shouldn't it be v0.27.4 in the doc instead of v0.27.3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's likely that it won't work if you try to use a snmp.yml file that does not match the snmp exporter version in your Alloy. This change will redirect users to the version of the snmp exporter that matches the one used in Alloy