-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the old peer discovery mechanism since v2 is default #1816
Conversation
Does this change the behavior any of join peers or the discovery string? Taking a quick look it doesnt appear to but want to double check. |
No, because it was default from the time we merged it. We had a way to switch back to the old discovery, and this is what we're removing here. There is also one feature that was enabled only for experimental users, but we tested it sufficiently too, so it's becoming the default. |
Did how used to handle |
It looks like it should work through the SRVResolver but its enough different I am unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b9a2e9e
to
af36368
Compare
Sorry for the confusion. As discussed offline - we currently use v2 by default and we had a flag that allowed to switch back to v1 in case of issues. Since v2 works fine, I'm removing the flag and deleting the v1. There are no changes required by users, this is fully compatible with old configs. |
PR Description
Now that we had run this code for a while, we're happy to remove the old v1 cluster peer discovery mechanism since the v2 works without issues as a drop-in replacement.
Which issue(s) this PR fixes
Fixes #1274
Notes to the Reviewer
PR Checklist