Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recently_active_only to prometheus.exporter.cloudwatch discovery block #1685

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Sep 13, 2024

PR Description

This was discussed on another PR.

There's no need to update converters, because this feature is not in Static mode.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ptodev ptodev requested review from clayton-cornell and a team as code owners September 13, 2024 18:05
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Sep 17, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are OK

@ptodev ptodev force-pushed the ptodev/recently_active_only branch from 9f8ca3b to 8e806a7 Compare October 17, 2024 14:28
@ptodev ptodev enabled auto-merge (squash) October 17, 2024 14:29
@ptodev ptodev merged commit 05a9670 into main Oct 17, 2024
17 of 18 checks passed
@ptodev ptodev deleted the ptodev/recently_active_only branch October 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants