Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New otelcol.exporter.debug component #1043

Merged
merged 5 commits into from
Jul 31, 2024
Merged

New otelcol.exporter.debug component #1043

merged 5 commits into from
Jul 31, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Jun 13, 2024

PR Description

The debug exporter is a replacement for the logging exporter. This exporter was also added to the Agent.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ptodev ptodev force-pushed the ptodev/add-debug-exporter branch 2 times, most recently from c7e15cd to 738866f Compare June 13, 2024 16:53
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jun 14, 2024

This comment was marked as outdated.

@wildum
Copy link
Contributor

wildum commented Jul 24, 2024

Do you think that we need this component now that we have the live debugging feature which supports all otel receivers and processors?
This component: shows only the output of the pipeline, the data is mixed with logs from Alloy, it has sample rate and verbosity features
Live debugging: can show the output of any steps in the pipeline without modifying the original pipeline, the data is separated from Alloy's logs, it has filtering, sample rate, pause/unpause, copy to clipboard features. For the cons the user needs an access to the UI and it's an experimental feature still

@ptodev
Copy link
Contributor Author

ptodev commented Jul 24, 2024

@wildum I agree that in the long term we should recommend that people use Live Debugging. However, I think there will always be a need for us to have this exporter:

  • The logs it produces could be sent to Loki
  • It's a useful component for the upstream Collector, and folks who are used to it might want to still use it. They might have already established processes around this.
  • It might be necessary for some config conversions between upstream yaml and Alloy syntax.

In the long term, I think we should keep this component but we can have a banner in the docs that recommends Live Debugging instead.

@clayton-cornell
Copy link
Contributor

Docs look OK to me now. :-)

@ptodev ptodev force-pushed the ptodev/add-debug-exporter branch from 5c33fac to bf63ea6 Compare July 30, 2024 18:06
@ptodev ptodev requested a review from wildum July 30, 2024 18:07
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

@ptodev ptodev merged commit b068c13 into main Jul 31, 2024
18 checks passed
@ptodev ptodev deleted the ptodev/add-debug-exporter branch July 31, 2024 17:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants