Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bring back testcontainers tests #6957

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mdelapenya
Copy link

@mdelapenya mdelapenya commented Jun 12, 2024

Hi from the Testcontainers community! 👋

PR Description

This PR bumps the version of Testcontainers for Go, to the latest released: v0.31.0, unskipping all the tests from the code (skipped in #4413).

At the same time, given the project uses testcontainers-go for Vault, I'm including the vault module, in case it's useful.

Which issue(s) this PR fixes

Notes to the Reviewer

I've run the Vault tests locally, even the dev port is using the default in the module (8200/tcp, here it was 80/tcp).

I'm currently checking the existing backlog, and #6670 could conflict with this one, as it keeps some t.Skip but not for testcontainers reasons.
See https://github.com/grafana/agent/pull/6670/files#diff-1f0f435cab418ca5c8a2e2d6411411bcaf85c131298e21082678de8a33f1adc1R143

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-attention An issue or PR has been sitting around and needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants