pyroscope.scrape: Standarize profile names

[simonswine]

When a user adopts godeltaprof_, currently the resulting profile typename is shown separately from the default ones. That makes is harder than it should be to adopt godeltaprof.

I am proposing that we send the profiles still under the name without the godeltaprof prefix.

@korniltsev do you think this might break anything down the line? I don't think so

@aknuds1 reported that initially

[tpaschalis]

LGTM personally, if @korniltsev is OK with it then we can merge.

[korniltsev]

LGTM with some notes

There is a piece of code determining if we should compute delta based on labels
https://github.com/grafana/agent/blob/6eb188959fe1dafda56ed34a8fb7c7fb9832ec99/component/pyroscope/scrape/scrape_loop.go#L188-L187

It looks like it is using allLabels , not the modified publicLabels so we should be ok there. I would maybe write a test to make sure delta appender is never used for godeltaprof renamed targets.

Another issue we could have is hash collision in case when there are 2 targets with memory and godeltaprof memory, the hash is calculated on public labels and they may end up the same after renaming. Not sure what to do best here. Maybe do not allow scraping godelttaprof_memory and memory at the same time from the same component?

[github-actions]

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

[simonswine]

This is now covered by: grafana/alloy#662