Allow the Host interface to return services. #6348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method on the Host interface allows services to call out to other services during runtime. Signed-off-by: Paschalis Tsilias <[email protected]>
This commit introduces a service.Provider interface as a counterpart to component.Provider. Signed-off-by: Paschalis Tsilias <[email protected]>
Using the previous commits as groundwork, we can now directly call to the clustering service from the web/api package. Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
rfratto
approved these changes
Feb 9, 2024
| @@ -26,6 +26,15 @@ func (f *Flow) GetServiceConsumers(serviceName string) []service.Consumer { | |||
| return consumers | |||
| } | |||
|
|
|||
| func (f *Flow) GetService(name string) (service.Service, bool) { | |||
service/service.go
Outdated
Comment on lines
40
to
44
| // A Provider exposes information around services. | ||
| type Provider interface { | ||
| // GetService looks up a running service using its name. | ||
| GetService(name string) (Service, bool) | ||
| } |
There was a problem hiding this comment.
I'm guessing we need this and can't just use service.Host?
There was a problem hiding this comment.
I thought that maybe there was a reason we'd hooked it up as component.Provider in web/api, but yeah, we can use service.Host directly here.
This commit removes the service.Provider interface since web/api can use service.Host itself as an implementation for retrieving components and services. Signed-off-by: Paschalis Tsilias <[email protected]>
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR enables the Host interface to access other running services. Currently, this simplifies the handling around the UI service and the cluster.Cluster interface it calls to, but in the future this can also help the remotecfg service populate some UI interface.
Which issue(s) this PR fixes
No issue filed.
Notes to the Reviewer
cc @rfratto from a TODO comment as he's already thought about this in the past.
PR Checklist