Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp): prevent divide-by-zero error when calculating array size for sharded targets #6326

Merged

Conversation

hainenber
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Fixes #6316

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@hainenber hainenber changed the title fix(comp): prevent divide-by-zero err when calculating array size for sharded targets fix(comp): prevent divide-by-zero error when calculating array size for sharded targets Feb 7, 2024
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always! One comment on the changes, but LGTM after that

component/discovery/discovery.go Outdated Show resolved Hide resolved
component/loki/source/podlogs/reconciler.go Outdated Show resolved Hide resolved
@rfratto rfratto enabled auto-merge (squash) February 8, 2024 03:01
@rfratto rfratto merged commit 1a035ee into grafana:main Feb 8, 2024
10 checks passed
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide by zero when sharding targets
2 participants