Add track_timestamps_staleness #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added upstream 4 months ago: prometheus/prometheus#13060
rfratto
approved these changes
Feb 6, 2024
| Scheme: "http", | ||
| HonorLabels: false, | ||
| HonorTimestamps: true, | ||
| TrackTimestampsStaleness: false, |
There was a problem hiding this comment.
@bboreham If you want to set the default to true, this is the place to do it.
| @@ -51,6 +51,7 @@ Name | Type | Description | Default | Required | |||
| `enable_protobuf_negotiation` | `bool` | Whether to enable protobuf negotiation with the client. | `false` | no | |||
| `honor_labels` | `bool` | Indicator whether the scraped metrics should remain unmodified. | `false` | no | |||
| `honor_timestamps` | `bool` | Indicator whether the scraped timestamps should be respected. | `true` | no | |||
| `track_timestamps_staleness` | `bool` | Indicator whether to track the staleness of the scraped timestamps. | `false` | no | |||
There was a problem hiding this comment.
@bboreham If you want to change the default to true, this also needs to be updated.
Yes I absolutely do, this is the correct setting for most people. There was a lot of debate at #5972 (review) |
|
However it may be appropriate to merge this PR, which is just allowing the config, then do a separate PR where we start arguing again. |
Sure, if you think that's easier 👍 merging |
clayton-cornell
added
the
type/docs
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
Added upstream 4 months ago: prometheus/prometheus#13060 Co-authored-by: Paulin Todev <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Added upstream 4 months ago: prometheus/prometheus#13060
Which issue(s) this PR fixes
#5921
Notes to the Reviewer
I have cherry-picked the commit originally in #5972; I did not yet change the default to true, because I'm unsure where that would go.
PR Checklist