-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyroscope: change demangle default value from none
to full
#6191
base: main
Are you sure you want to change the base?
Conversation
See this thread for more info: https://raintank-corp.slack.com/archives/C048VSWPZ4P/p1705604141660129 cc @korniltsev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made it none by default as a premature optimization.
I dont like changing it to full as current implementation will process each symbol even when we dont need any processing, even if it is golang or python.
For example grafana workloads doe not need this default.
You probably need to update changlog |
Other things to consider in the future:
|
You probably need to update docs with the new default |
This PR has not had any activity in the past 30 days, so the |
See this thread for more info: https://raintank-corp.slack.com/archives/C048VSWPZ4P/p1705604141660129
cc @korniltsev — WDYT?