Add fix for process and include details on crash behavior. #5866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clayton-cornell is this the right use of the admonition note? |
docs/sources/flow/reference/components/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
Almost. There was a missing space in the closing element |
clayton-cornell
added
the
type/docs
…dows.md Co-authored-by: Clayton Cornell <[email protected]>
erikbaranowski
approved these changes
Nov 28, 2023
docs/sources/flow/reference/components/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
1 task
This was referenced Jan 8, 2024
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
) * Add fix for process and include details on crash behavior. * Update docs/sources/flow/reference/components/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <[email protected]> * Clean up wording. --------- Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This updates windows_exporter to a version that handles the process config correctly and no longer lets a nil slip through.
Which issue(s) this PR fixes
Fixes #5855
Notes to the Reviewer
Ran with the default configuration for all the available collectors except for the ones mentioned in the admonition since those caused panics when calling underlying windows layer.
PR Checklist
Did not update the changelog since it falls under my previous change of fixing defaults.