Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the url links #5850

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Fixed the url links #5850

merged 1 commit into from
Nov 24, 2023

Conversation

htcosta
Copy link
Contributor

@htcosta htcosta commented Nov 24, 2023

PR Description

Links not displaying correctly, due to concatenation of two markdown elements.

Which issue(s) this PR fixes

Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the link element.
This PR fixes these two entries.

Notes to the Reviewer

PR Checklist

Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.
@CLAassistant
Copy link

CLAassistant commented Nov 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this! These things slip through from time to time.

@clayton-cornell clayton-cornell enabled auto-merge (squash) November 24, 2023 21:02
@clayton-cornell clayton-cornell merged commit b18609d into grafana:main Nov 24, 2023
14 checks passed
grafanabot pushed a commit that referenced this pull request Nov 24, 2023
Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.

(cherry picked from commit b18609d)
grafanabot pushed a commit that referenced this pull request Nov 24, 2023
Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.

(cherry picked from commit b18609d)
grafanabot pushed a commit that referenced this pull request Nov 24, 2023
Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.

(cherry picked from commit b18609d)
@htcosta htcosta deleted the patch-1 branch November 24, 2023 21:10
clayton-cornell pushed a commit that referenced this pull request Nov 24, 2023
Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.

(cherry picked from commit b18609d)

Co-authored-by: Helder Costa <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Nov 24, 2023
Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.

(cherry picked from commit b18609d)

Co-authored-by: Helder Costa <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Nov 24, 2023
Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.

(cherry picked from commit b18609d)

Co-authored-by: Helder Costa <[email protected]>
hainenber pushed a commit to hainenber/agent that referenced this pull request Nov 25, 2023
Backticks should be used inside the link text, to properly be displayed as inline code style, while still preserving the url link.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.36 backport release-v0.37 backport release-v0.38 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants