MSSQL Integration: Adds query_config_path to allow for custom metrics through custom exporter config file #5768
Conversation
| @@ -40,6 +41,7 @@ type Arguments struct { | |||
| MaxIdleConnections int `river:"max_idle_connections,attr,optional"` | |||
| MaxOpenConnections int `river:"max_open_connections,attr,optional"` | |||
| Timeout time.Duration `river:"timeout,attr,optional"` | |||
| QueryConfigPath string `river:"query_config_path,attr,optional"` | |||
There was a problem hiding this comment.
The more river centric path for this would for this to be query_config and allow them to use local.file to get the content. That way they could get it in a myriad number of ways or inline if they really really wanted to.
| if errors.Is(err, os.ErrNotExist) { | ||
| return errors.New("query_config_path must be a valid path of a YAML config file") | ||
| } else { | ||
| return errors.New("query_config_path file has issues") |
There was a problem hiding this comment.
We should wrap or fmt.Error the existing error from stat.
docs/sources/flow/reference/components/prometheus.exporter.mssql.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/prometheus.exporter.mssql.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/prometheus.exporter.mssql.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
|
@mattdurham @clayton-cornell Hello. I've looked at your feedback and made changes. I ended up going further and makign both a query_config_file and query_config to closer match the patterns of SNMP and Blackbox. Let me know what you think. Thanks! |
docs/sources/flow/reference/components/prometheus.exporter.mssql.md
Outdated
Show resolved
Hide resolved
|
Getting a lint error. |
|
@clayton-cornell could you run the last test? It is hard to ensure locally, as I seem to get a bunch of linter errors outside of the integration under change that don't appear to show up in the CI. |
…cs through custom exporter config file
|
Approved it to run. |
|
@StefanKurek @mattdurham It's passing the build now. Since it's reviewed and approved, I'll merge it into Main. :-) |
… through custom exporter config file (grafana#5768) * Adds query_config_path to mssql integration to allow for custom metrics through custom exporter config file * Updates query_config_path to agent flow and fixes tests/docs * Adds both query_config and query_config_file to mssql integration * Removes query_config_file from mssql config params
github-actions
bot
added
the
frozen-due-to-age
PR Description
MSSQL Integration: Adds query_config_path to allow for custom metrics through custom exporter config file.
Updates both integration and relevant documentation.
Which issue(s) this PR fixes
NA
Notes to the Reviewer
PR Checklist