Fixing example in remote.kubernetes.secret.md to include nonsensitive() #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prometheus.remote_write basic_auth username is a string type and the agent will non start if the username is provided directly as a secret out of remote.kubernetes.secret.
|
|
clayton-cornell
added
type/docs
clayton-cornell
approved these changes
Nov 3, 2023
grafanabot
pushed a commit
that referenced
this pull request
Nov 3, 2023
…() (#5704) The prometheus.remote_write basic_auth username is a string type and the agent will non start if the username is provided directly as a secret out of remote.kubernetes.secret. Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit ffccd0a)
clayton-cornell
pushed a commit
that referenced
this pull request
Nov 8, 2023
…() (#5704) (#5711) The prometheus.remote_write basic_auth username is a string type and the agent will non start if the username is provided directly as a secret out of remote.kubernetes.secret. Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit ffccd0a) Co-authored-by: Nicolai Hornung <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The prometheus.remote_write > basic_auth > username is a string type and the agent will non start if the username is provided directly as a secret out of remote.kubernetes.secret as done in the example. nonsensitive() needs to be added to it for the config to be valid.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist