Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent Management] Support External Labels from API #5670

Merged

Conversation

spartan0x117
Copy link
Contributor

PR Description

Adds support for optional response from the API (agent_metadata: {external_labels: {...}}). External labels supplied by the API in this way will only add to (not override) any existing external labels.

  • Tests updated

Copy link
Contributor

@jcreixell jcreixell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@spartan0x117 spartan0x117 merged commit 1c83946 into main Nov 1, 2023
10 checks passed
@spartan0x117 spartan0x117 deleted the spartan0x117/agent-management-add-external-labels-support branch November 1, 2023 22:49
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants