Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faro: include measurement type #5654

Merged
merged 1 commit into from
Oct 31, 2023
Merged

faro: include measurement type #5654

merged 1 commit into from
Oct 31, 2023

Conversation

rlankfo
Copy link
Member

@rlankfo rlankfo commented Oct 30, 2023 •
edited
Loading

PR Description

This includes the measurement type field for Faro payloads in the flow component or the legacy integration.

Which issue(s) this PR fixes

Fixes #5667

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@rlankfo rlankfo requested review from a team as code owners October 30, 2023 18:34
marctc
marctc approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marctc marctc enabled auto-merge (squash) October 31, 2023 09:32
@rlankfo
faro: include measurement type
7e2e890 
Signed-off-by: Robbie Lankford <[email protected]>
@rlankfo rlankfo force-pushed the rlankfo/faro-measurement-type branch from 7600a68 to 7e2e890 Compare October 31, 2023 17:16
@marctc marctc merged commit d5ba228 into grafana:main Oct 31, 2023
10 checks passed
hainenber pushed a commit to hainenber/agent that referenced this pull request Nov 1, 2023
@rlankfo @hainenber
faro: include measurement type (grafana#5654)
9ad3748 
Signed-off-by: Robbie Lankford <[email protected]>
vanugrah added a commit to vanugrah/agent that referenced this pull request Feb 16, 2024
@vanugrah
Update payload.go
121ae66 
The proposed change was missed in this PR: 
grafana#5654
@vanugrah vanugrah mentioned this pull request Feb 16, 2024
Merged
4 tasks
rlankfo pushed a commit that referenced this pull request Feb 20, 2024
@vanugrah
Update payload.go Measurement KeyVals() to handle type in app_agent_r…
6c0032d 
…eceiver (#6380)

* Update payload.go

The proposed change was missed in this PR: 
#5654

* update test. Add changelog entry.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marctc marctc marctc approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[integration: app_agent_receiver]'type' keyval is not handled in the log's measurement
2 participants
@rlankfo @marctc