Sortable header for component list in web UI #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
requested changes
Oct 29, 2023
|
hi there, all of your proposals are implemented, I wholeheartedly agreed with all of them. The added changes don't change the sorting logic and visuals, so the video still stays valid. PTAL if you have time again. Thank you! |
wildum
requested changes
Oct 31, 2023
|
One more thing, after discussing with our new UX designer, we would like to have by default the sorting enabled with ID "asc". This way the arrow will already be shown and it's easier for the user to find the sorting functionality |
hainenber
requested review from
a team,
clayton-cornell and
jdbaldry
as code owners
|
|
hainenber
force-pushed
the
sortable-component-header-table
branch
from
b29b436
to
596b798
Compare
|
Hey, thanks for another review. I've made the refactor to simplify the sorting logic here and there as well as making ID column to be sorted ascendingly by default. PTAL again |
wildum
requested changes
Nov 2, 2023
wildum
reviewed
Nov 2, 2023
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Co-authored-by: William Dumont <[email protected]>
Signed-off-by: hainenber <[email protected]>
…rafana#5634) * Add an "exclude_event_message" argument to loki.source.windowsevent * Add a note with exact commit hash of Loki. --------- Co-authored-by: Paschalis Tsilias <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Co-authored-by: William Dumont <[email protected]>
hainenber
force-pushed
the
sortable-component-header-table
branch
from
aca2060
to
3aa815e
Compare
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
wildum
reviewed
Nov 2, 2023
Signed-off-by: hainenber <[email protected]>
wildum
approved these changes
Nov 2, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Implements grafana/alloy#321
Notes to the Reviewer
Please check if the screen recording is as expected or something more formal needs to be done, i.e. tests
Screen.Recording.2023-10-28.at.20.51.24.mov
PR Checklist