initial wiring agent integration for integration-next #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
erikbaranowski
commented
Oct 30, 2023
converter/internal/staticconvert/internal/build/agent_exporter.go
Outdated
Show resolved
Hide resolved
mattdurham
reviewed
Oct 31, 2023
|
|
||
| switch itg := integration.(type) { | ||
| case *agent_exporter_v2.Config: | ||
| exports = b.appendAgentExporter(itg) |
There was a problem hiding this comment.
This feels off and maybe a comment/naming would fix it. In a lot of places v2 is used but this looks wrong especially with the appendExporterV2 a few lines below. Looking into the func it pivots but feels like friction here.
Signed-off-by: erikbaranowski <[email protected]>
hainenber
pushed a commit
to hainenber/agent
that referenced
this pull request
Nov 1, 2023
* initial wiring agent integration for integration-next Signed-off-by: erikbaranowski <[email protected]> --------- Signed-off-by: erikbaranowski <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR wires up the first integration for static converter integrations-next. It implements all the underlying shared code necessary to wire up additional integrations.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist