Clarify use of send_batch_max_size in otelcol.processor.batch #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
the
type/docs
clayton-cornell
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
@ptodev Sorry for the late review. This one slipped through on me
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been som understandable confusion about the behaviour of the
send_batch_max_sizeargument in theotelcol.processor.batchcomponent. I browsed the OTel docs and code to double check how it works and I'm clarifying it in this PR.