Move positions file to being bbolt instead of raw file #5539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Instead of using a raw file with xml which is prone to problems in the case of a hard reboot, switched to using bbolt. bbolt is the storage backend for etcd so is mature and has a team behind it. In testing it created a 32kb file, which looks to be the minimum file size even though its not storing very much text. This code also attempts to transition their old xml, assuming they are using the defaults.
Which issue(s) this PR fixes
Closes #4916
Notes to the Reviewer
This is a step to test out using a kv store for more usages beyond this singular usage.
PR Checklist