Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github exporter #3564

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Update github exporter #3564

merged 3 commits into from
Apr 18, 2023

Conversation

jcreixell
Copy link
Contributor

@jcreixell jcreixell commented Apr 18, 2023

PR Description

Which issue(s) this PR fixes

Fixes #3144
Closes #3417

PR Checklist

  • CHANGELOG updated

  - Fixes a bug that would cause the exporter to get stuck in an
    infinite loop when the github API returns an error.
  - See grafana/github-exporter#1
  - Switches to grafana's fork instead of rgeyer's one.
@jcreixell jcreixell requested review from marctc and rgeyer April 18, 2023 10:45
Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

go.mod Show resolved Hide resolved
@jcreixell jcreixell merged commit 7ae85c7 into main Apr 18, 2023
@jcreixell jcreixell deleted the update-github-exporter branch April 18, 2023 14:36
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
* Update github exporter

  - Fixes a bug that would cause the exporter to get stuck in an
    infinite loop when the github API returns an error.
  - See grafana/github-exporter#1
  - Switches to grafana's fork instead of rgeyer's one.

* Add clarifying comment
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
* Update github exporter

  - Fixes a bug that would cause the exporter to get stuck in an
    infinite loop when the github API returns an error.
  - See grafana/github-exporter#1
  - Switches to grafana's fork instead of rgeyer's one.

* Add clarifying comment
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
2 participants