Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Multi-tenancy support in Flow #2583

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Dec 2, 2022

Proposes several approaches to support (or not) multi-tenancy within Flow. Solves grafana/alloy#521.

@ptodev ptodev marked this pull request as draft December 2, 2022 12:33
@ptodev ptodev changed the title An RFC for multi-tenancy [RFC] Multi-tenancy support in Flow Dec 2, 2022

### Solution 2 - A generic "sharding" configuration for the Agent remote write

The [```prometheus.remote_write```](https://grafana.com/docs/agent/latest/flow/reference/components/prometheus.remote_write/) Flow component could be expanded to be able to shard the writes into different remote writes under the hood. Each of these shards would have its own write-ahead log (WAL). Also, each shard would be able to remote write to a different endpoint address and with different HTTP header information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Caching of series refs is per WAL, so if tenants have a lot of overlap with series, this can lead to ballooning memory usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thank you, I added this to the "cons" list. Although not sure if it's a "con" it's more like just something to keep in mind.

@mattdurham
Copy link
Collaborator

There is also https://github.com/blind-oracle/cortex-tenant which seems to fit the needs?

@ptodev
Copy link
Contributor Author

ptodev commented Jan 12, 2023

There is also https://github.com/blind-oracle/cortex-tenant which seems to fit the needs?

Of course! How could I forget 😆 Thanks for reminding me, I added that too.

@tpaschalis tpaschalis removed their request for review January 11, 2024 10:00
@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow: Add component for multi-tenant remote_write support
3 participants