fix(pyroscope.ebpf): remove undocumented fields (#6267)

grafana · Jan 29, 2024 · 49bfc29 · 49bfc29
1 parent 007070d
commit 49bfc29
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/component/pyroscope/ebpf/args.go b/component/pyroscope/ebpf/args.go
@@ -10,8 +10,6 @@ import (
 type Arguments struct {
 	ForwardTo            []pyroscope.Appendable `river:"forward_to,attr"`
 	Targets              []discovery.Target     `river:"targets,attr,optional"`
-	DefaultTarget        discovery.Target       `river:"default_target,attr,optional"` // undocumented, keeping it until we have other sd
-	TargetsOnly          bool                   `river:"targets_only,attr,optional"`   // undocumented, keeping it until we have other sd
 	CollectInterval      time.Duration          `river:"collect_interval,attr,optional"`
 	SampleRate           int                    `river:"sample_rate,attr,optional"`
 	PidCacheSize         int                    `river:"pid_cache_size,attr,optional"`

diff --git a/component/pyroscope/ebpf/ebpf_linux.go b/component/pyroscope/ebpf/ebpf_linux.go
@@ -82,7 +82,6 @@ func defaultArguments() Arguments {
 		CacheRounds:          3,
 		CollectUserProfile:   true,
 		CollectKernelProfile: true,
-		TargetsOnly:          true,
 		Demangle:             "none",
 		PythonEnabled:        true,
 	}
@@ -226,8 +225,7 @@ func targetsOptionFromArgs(args Arguments) sd.TargetsOptions {
 	}
 	return sd.TargetsOptions{
 		Targets:            targets,
-		DefaultTarget:      sd.DiscoveryTarget(args.DefaultTarget),
-		TargetsOnly:        args.TargetsOnly,
+		TargetsOnly:        true,
 		ContainerCacheSize: args.ContainerIDCacheSize,
 	}
 }