do not convert measurement values to strings

grafana · Apr 5, 2024 · 1b2fcae · 1b2fcae
1 parent f904c53
commit 1b2fcae
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/internal/component/faro/receiver/internal/payload/payload.go b/internal/component/faro/receiver/internal/payload/payload.go
@@ -239,12 +239,12 @@ func (m Measurement) KeyVal() *KeyVal {
 	MergeKeyVal(kv, m.Trace.KeyVal())
 	MergeKeyValWithPrefix(kv, KeyValFromMap(m.Context), "context_")
 
-	valuesAsString := make(map[string]string, len(m.Values))
+	values := make(map[string]float64, len(m.Values))
 	for key, value := range m.Values {
-		valuesAsString[key] = fmt.Sprintf("%v", value)
+		values[key] = value
 	}
 
-	MergeKeyValWithPrefix(kv, KeyValFromMap(valuesAsString), "value_")
+	MergeKeyValWithPrefix(kv, KeyValFromFloatMap(values), "value_")
 
 	return kv
 }

diff --git a/internal/component/faro/receiver/internal/payload/utils.go b/internal/component/faro/receiver/internal/payload/utils.go
@@ -29,6 +29,20 @@ func KeyValFromMap(m map[string]string) *KeyVal {
 	return kv
 }
 
+// KeyValFromMap will instantiate KeyVal from a map[string]float64
+func KeyValFromFloatMap(m map[string]float64) *KeyVal {
+	kv := NewKeyVal()
+	keys := make([]string, 0, len(m))
+	for k := range m {
+		keys = append(keys, k)
+	}
+	sort.Strings(keys)
+	for _, k := range keys {
+		kv.Set(k, m[k])
+	}
+	return kv
+}
+
 // MergeKeyVal will merge source in target
 func MergeKeyVal(target *KeyVal, source *KeyVal) {
 	for el := source.Oldest(); el != nil; el = el.Next() {