Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API method get_alertrules_all #97

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

harish422
Copy link
Contributor

added rest api for v1/provisioning/alert-rules

@harish422 harish422 requested a review from amotl as a code owner July 29, 2023 06:51
@amotl amotl changed the title added api get_alertrules_all Add API method get_alertrules_all Jul 30, 2023
@amotl
Copy link
Contributor

amotl commented Jul 30, 2023

Thank you very much for your contribution. I've reformatted the code, added a test case, and a corresponding changelog item.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #97 (8d01c16) into main (07bbe2a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   97.58%   97.59%           
=======================================
  Files          24       24           
  Lines        1452     1456    +4     
=======================================
+ Hits         1417     1421    +4     
  Misses         35       35           
Files Changed Coverage Δ
grafana_client/elements/alertingprovisioning.py 58.75% <100.00%> (+2.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Added REST API wrapper for v1/provisioning/alert-rules.
@amotl amotl merged commit ba367cd into grafana-toolbox:main Jul 30, 2023
12 checks passed
@amotl
Copy link
Contributor

amotl commented Jul 30, 2023

Your improvement has been released with 3.6.0. Thanks again.

@harish422 harish422 deleted the patch-1 branch July 31, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants