Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting the session pool size in niquests #190

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

sjoeboo
Copy link
Contributor

@sjoeboo sjoeboo commented Oct 18, 2024

Description

adds ability to set the session pool size in niquests when needed:

grafana = GrafanaApi.from_url(
    url=GRAFANA_URL, credential=TokenAuth(token=GRAFANA_API_TOKEN)
)
grafana.client.timeout = 60
grafana.client.session_pool_size = 32

Checklist

  • The patch has appropriate test coverage
  • The patch follows the style guidelines of this project
  • The patch has appropriate comments, particularly in hard-to-understand areas
  • The documentation was updated corresponding to the patch
  • I have performed a self-review of this patch

@sjoeboo sjoeboo requested a review from amotl as a code owner October 18, 2024 13:45
@sjoeboo
Copy link
Contributor Author

sjoeboo commented Oct 18, 2024

addresses #189

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (7303ec2) to head (dcca2ae).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   94.44%   92.29%   -2.16%     
==========================================
  Files          26       27       +1     
  Lines        1711     1816     +105     
==========================================
+ Hits         1616     1676      +60     
- Misses         95      140      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amotl amotl merged commit 36a2386 into grafana-toolbox:main Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants