Refine API wrapper for "Plugins" #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
plugins-refine
branch
from
9541818
to
30a0c40
Compare
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 95.15% 94.85% -0.31%
==========================================
Files 25 25
Lines 1590 1594 +4
==========================================
- Hits 1513 1512 -1
- Misses 77 82 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bhks
reviewed
Sep 20, 2023
| except Exception as ex: | ||
| self.logger.info("Got error in fetching metrics for plugin %s and error = %s", pluginId, ex) | ||
| return None | ||
| path = "/plugins/%s/metrics" % pluginId |
There was a problem hiding this comment.
Thanks for refactoring. I should have put more focus here since that was my local logging to help identify if plugin does not have metrics endpoint.
bhks
reviewed
Sep 20, 2023
| @@ -34,10 +26,15 @@ def install_plugin(self, pluginId, version): | |||
| r = self.client.POST(path, json={"version": version}) | |||
| return r | |||
| except Exception as ex: | |||
| self.logger.info("Skipped installing %s and err = %s", pluginId, ex) | |||
| if errors == "raise": | |||
There was a problem hiding this comment.
Great one, thanks for helping raise the quality.
bhks
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This patch refines GH-110 by @bhks a bit. First, the wrapper functions in the other subsystem implementations usually do not catch exceptions, which led to an anomaly in error handling at grafana-toolbox/grafana-wtf#91. In order to align it to the other wrapper implementations, I've removed catching exceptions in the
get_plugin_metricsfunction.On the other hand, I've added error handling to the
{install,uninstall}_pluginfunctions, now raising errors by default, but providing the possibility to ignore them.