Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable_provenance parameter to applicable method calls #107

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

beeradb
Copy link
Collaborator

@beeradb beeradb commented Sep 7, 2023

Description

As of grafana/grafana#63650 the X-Disable-Provenance header is also valid on the following endpionts:

  • POST /api/v1/provisioning/alert-rules
  • PUT /api/v1/provisioning/folder/{FolderUID}/rule-groups/{Group} (calling this endpoint will change provenance for all alert rules within the alert group)
  • POST /api/v1/provisioning/contact-points
  • POST /api/v1/provisioning/mute-timings
  • PUT /api/v1/provisioning/policies
  • PUT /api/v1/provisioning/templates/{name}

With that in mind, this PR expands support for this parameter to the affected resources.

@beeradb beeradb requested a review from amotl as a code owner September 7, 2023 17:39
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #107 (40b3d0a) into main (5afaaa6) will decrease coverage by 0.99%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   97.34%   96.36%   -0.99%     
==========================================
  Files          24       24              
  Lines        1471     1486      +15     
==========================================
  Hits         1432     1432              
- Misses         39       54      +15     
Files Changed Coverage Δ
grafana_client/elements/alertingprovisioning.py 48.51% <21.42%> (-8.47%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@amotl
Copy link
Contributor

amotl commented Sep 7, 2023

Dear Brad,

thank you very much for submitting this patch. I do not have any objections. Other than my little question below, the patch needs a rebase, because I've just merged GH-108 before.

With kind regards,
Andreas.

@amotl amotl changed the title Add disable_provenenace paramter to applicable method calls Add disable_provenance parameter to applicable method calls Sep 7, 2023
@amotl amotl merged commit 37ec223 into grafana-toolbox:main Sep 8, 2023
6 checks passed
@beeradb
Copy link
Collaborator Author

beeradb commented Sep 8, 2023

Thanks @amotl!

I'm not sure what your release cadence is for this project, but would it be possible to cut a new release with these changes sometime soon?

Thanks for all the work you've done on this client.

@amotl
Copy link
Contributor

amotl commented Sep 8, 2023

grafana-client 3.7.0 has just been released, including your improvements. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants