Plugins: Accept empty JSON response on plugin uninstall

grafana-toolbox · Sep 21, 2023 · 38757d4 · 38757d4
1 parent 5c79d9d
commit 38757d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## unreleased
 
+* Plugins: Accept empty JSON response on plugin uninstall
+
 
 ## 3.9.0 (2023-09-21)
 

diff --git a/grafana_client/elements/plugin.py b/grafana_client/elements/plugin.py
@@ -55,7 +55,9 @@ def uninstall(self, plugin_id, errors="raise"):
         """
         try:
             path = "/plugins/%s/uninstall" % plugin_id
-            r = self.client.POST(path)
+            # Unfortunately, this endpoint may respond with an empty JSON,
+            # which needs compensation, because it does not decode well.
+            r = self.client.POST(path, accept_empty_json=True)
             return r
         except Exception as ex:
             if errors == "raise":