Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the published experimental declarative plugins #25

Open
wants to merge 2 commits into
base: main-declarative
Choose a base branch
from

Conversation

octylFractal
Copy link
Member

Waiting on gradle/declarative-gradle#61 to fix & publish a new version before being ready.

@octylFractal octylFractal added the enhancement New feature or request label May 17, 2024
@octylFractal octylFractal self-assigned this May 17, 2024
@octylFractal octylFractal force-pushed the ot/feature/use-published-declarative-plugins branch from f886f1c to 83218f6 Compare June 12, 2024 15:57
@octylFractal octylFractal marked this pull request as ready for review June 12, 2024 16:16
@octylFractal
Copy link
Member Author

@tresat I think the failures are unrelated to these changes, do you know if main-declarative has been building for you?

@tresat
Copy link
Member

tresat commented Jun 13, 2024

@tresat I think the failures are unrelated to these changes, do you know if main-declarative has been building for you?

IDK. The :app:connectedDemoDebugAndroidTest task that failed in the Build / androidTest (30) (pull_request) also fails for me locally with my current changes (if I have a running device in the emulator for it to test on), but with a different error: Test run failed to complete. Instrumentation run failed due to Process crashed..

I'm not sure exactly what is contained in this published version of the declarative prototype, but it's probably less important than the significant changes waiting on review there that will support declarativizing NiA's application projects. I'd wait for those to be merged and a new plugin version published before spending much time troubleshooting this build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants