Use Java 17 for most of gradle-profiler tests #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we will upgrade Android Studio that supports just Java 17. Additionally in the future Gradle will support only Java 17. We will keep Linux running with Java 8 for now.
asodja
commented
Oct 28, 2024
.teamcity/settings/extensions.kt
Outdated
| """"-Porg.gradle.java.installations.paths=%${os.name}.java8.oracle.64bit%,%${os.name}.java11.openjdk.64bit%"""" | ||
| """"-Porg.gradle.java.installations.paths= | ||
| |%${os.name}.java8.oracle.64bit%, | ||
| |%${os.name}.java11.openjdk.64bit%, |
There was a problem hiding this comment.
💭 I left Java11 here, since without #579 merged we still use Java11 toolchains
…nstallations.path
cobexer
approved these changes
Oct 28, 2024
True, I removed some repetition by simplifying setting javaHome() |
|
It looks like this needs some more changes, since quite some number of tests break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will upgrade Android Studio that supports just Java 17. Additionally in the future Gradle will support only Java 17.
We will keep Linux running with Java 8 for now.