Enums and Settings #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0tk3y
force-pushed
the
sigushkin/enums-and-settings
branch
from
0fd1dcf
to
c01dd60
Compare
eskatos
reviewed
Sep 30, 2024
Comment on lines
147
to
148
| if (softwareTypeNode == null) { | ||
| Text("No software type") | ||
| SettingsModelContent(highlightedSourceRangeByFileId, selectedDocumentResult) |
There was a problem hiding this comment.
❓ Wouldn't softwareTypeNode be null also for an empty build.gradle.dcl file?
There was a problem hiding this comment.
Ah, you're right.
It would make some sense to show the top level model for empty projects, too, as that would list the available software types, but that would not be so pretty (it would also say "Step: project" and for each software type, list its top level model's properties). Let's bring back the stub and maybe improve the empty project view at some point later.
I've fixed it in 23d946a (#29)
eskatos
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings.gradle.dclas a document