Comment pull-request with Build Scan links in Publish action #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprinet
force-pushed
the
jprinet/comment-pr-with-build-scan-links
branch
from
5203859
to
3699e84
Compare
jprinet
force-pushed
the
jprinet/add-publish-maven-build-scan-action
branch
15 times, most recently
from
9741932
to
ffe1f1a
Compare
jprinet
force-pushed
the
jprinet/comment-pr-with-build-scan-links
branch
7 times, most recently
from
5f8d425
to
cb12371
Compare
jprinet
force-pushed
the
jprinet/add-publish-maven-build-scan-action
branch
from
ffe1f1a
to
ff543ce
Compare
jprinet
force-pushed
the
jprinet/comment-pr-with-build-scan-links
branch
5 times, most recently
from
78f4889
to
4b288d4
Compare
jprinet
force-pushed
the
jprinet/comment-pr-with-build-scan-links
branch
from
4b288d4
to
90c17d7
Compare
bigdaz
reviewed
Sep 21, 2023
maven/build-scan/publish/action.yml
Outdated
| scanLink=$(grep -A1 "Publishing build scan..." build.out | tail -n 1 | sed 's/\[INFO\] //') | ||
| if [[ ! -z "$scanLink" ]] | ||
| then | ||
| scanLinks="${scanLinks},[Link $((publishedScans++))]($scanLink)" |
There was a problem hiding this comment.
I think these links would be more useful if they were raw so the user could see the URL. If we have a nice human-readable text for the build then that would be good, but the "Link 1" text just obfuscates things.
jprinet
force-pushed
the
jprinet/add-publish-maven-build-scan-action
branch
from
5649d11
to
599b9f2
Compare
Base automatically changed from
jprinet/add-publish-maven-build-scan-action
to
main
September 26, 2023 10:09
jprinet
force-pushed
the
jprinet/comment-pr-with-build-scan-links
branch
from
ce120a8
to
ba6bf14
Compare
- One single job to publish Build Scans - Replace approve with accept
jprinet
force-pushed
the
jprinet/comment-pr-with-build-scan-links
branch
from
ba6bf14
to
f352754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds published Build Scan links as comments to the pull-request. This is required as there is no easy way to correlate the Workflow execution (not using a
pull_requesttrigger) with the original pull request.This happens by modifying the publish composite action.
Testing
Same as for the publish action, no testing is provided
Implementation Details
The
github-tokenis added as action inputs to allow commenting the pull-request.Preview
Shortcomings
The Build Scan link is retrieved by grepping the Maven console output which is not elegant.
This could be revisited once the Maven init action will be alive.
Comment
This PR has the
jprinet/add-publish-maven-build-scan-actionas base for clarity