Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fit to new fax api #17

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update fit to new fax api #17

wants to merge 1 commit into from

Conversation

gehring
Copy link
Contributor

@gehring gehring commented Jul 31, 2020

Currently requires using fax from the converge-test-override branch.

resolves #16

@gehring
Copy link
Contributor Author

gehring commented Jul 31, 2020

@lukasheinrich

@phinate
Copy link
Member

phinate commented Jul 31, 2020

Thanks for following things up with us @gehring! Indeed, neos is still very much active (and will continue to be) -- I've been getting my hands dirty with a refactor and redocumentation attempt on my own fork. Really appreciate your proactive issue raise.

Just FYI (for @lukasheinrich ), I did a quick test of this using fax@converge-test-override -- it definitely breaks something somewhere (loss is always 0 in the demo_softmax notebook, for example.)

The fit API will almost be unchanged with the refactor, so any solution found here will also be easy to merge down the line.

p.s. I've made sure to shout out you and fax in the 5 or 6 talks I've given on this :)

@lukasheinrich
Copy link
Collaborator

Thanks @gehring! I'll check this out in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to new upcoming fax API
3 participants