Simplify GraalPy starter #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
msimacek
previously approved these changes
Oct 9, 2024
|
|
||
| public class App { | ||
|
|
||
| public static void main(String[] args) { | ||
| try (Context context = GraalPyResources.createContext()) { | ||
| try (Context context = Context.create("python")) { |
There was a problem hiding this comment.
Should we add options for allowing IO/native/threads/etc and importing site? Maybe commented out with explanation "if you need X, uncomment Y"
timfel
force-pushed
the
tim/fix-graalpy-starter
branch
from
8894efb
to
d311b5e
Compare
msimacek
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using GraalPyResources is wrong and broken when no packages are actually used (because filelist will be missing), and since we have no Gradle plugin this cannot work correctly, yet, as soon as any user modifies the code to import some standard library it will just break. Simplify the starter to make this not happen.