Make ffi::Txt safer and simpler to use
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gquintard
reviewed
Sep 11, 2024
gquintard
reviewed
Sep 11, 2024
| // We expect varnishd to always given us a string with a ':' in it | ||
| // If it's not the case, blow up as it might be a sign of a bigger problem. | ||
| let (key, value) = self.to_str()?.split_once(':').unwrap(); | ||
| // FIXME: Consider `.trim_ascii_start()` if unicode is not a concern |
There was a problem hiding this comment.
header names will be ascii, so go for it
There was a problem hiding this comment.
header name is not the issue - .trim_start uses char::is_whitespace, whereas .trim_ascii_start only removes "ascii whitespace" by using u8::is_ascii_whitespace. Which means that if a header value can have non-ascii whitespace characters in the front, they will stay there. Let's merge and decide this separate?
Add a few helper methods to help with converting txt to str and back, which also helps with the header parsing. As a tiny addition, also simplified `TestCtx` instantiation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few helper methods to help with converting txt to str and back, which also helps with the header parsing. As a tiny addition, also simplified
TestCtxinstantiation.