Wrap VCL_BOOL in a struct to ensure type safety
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
gen-types-bool
branch
5 times, most recently
from
2126e36
to
fbaf072
Compare
nyurik
changed the title
VCL_BOOL in a struct to ensure type safety
wip Cleaned up boilerplate
nyurik
force-pushed
the
gen-types-bool
branch
from
fbaf072
to
337e512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a wrapper for
VCL_BOOLtype, per #51Open Questions
DerefandDerefMutimplementations for it? It can be simplified tostruct VCL_BOOL(pub c_uint);probe.exp_status = self.exp_status.into_vcl(ws)?and 2 more no longer work because it seem they were silently using int to bool conversion?vcl_types!?