Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core:hw to SigMF metadata files #1305

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add core:hw to SigMF metadata files #1305

merged 1 commit into from
Oct 6, 2023

Conversation

argilo
Copy link
Member

@argilo argilo commented Oct 6, 2023

This is a follow-up to #1182.

As noted in #1182 (comment), it would be useful to store input device metadata in the core:hw field, which the SigMF spec defines as:

A text description of the hardware used to make the Recording.

Unfortunately, the gr-osmosdr API does not appear to provide any means to fetch metadata about the device associated with a source block. Metadata about all scanned devices can be retrieved with osmosdr::device::find(), but there is no guarantee that the device selected by the device string matches one of the scanned devices. So I think the best we can do for now is write out the current device string, e.g. "core:hw": "airspyhf=0".

/cc @Niautanor

@argilo argilo added the feature label Oct 6, 2023
@willcode
Copy link
Contributor

willcode commented Oct 6, 2023

Too bad there's no way of declaring something purely informational. I can see someone parsing this string, since it means something to osmo. Maybe add a prefix? Something like
osmo://airspyhf=0
Not sure I really like that exact syntax though because we could potentially use a URI for something like ZMQ later. So,
osmo: airspyhf=0 would be a less formal way of saying the same thing. Just some ideas.

@argilo
Copy link
Member Author

argilo commented Oct 6, 2023

The spec sounds like it's meant to be human-readable. How about "gr-osmosdr device specification: airspyhf=0"?

@willcode
Copy link
Contributor

willcode commented Oct 6, 2023

A little less verbose would be nice, in case it's used in a title bar or something, but yah, something that doesn't look parseable.

@argilo
Copy link
Member Author

argilo commented Oct 6, 2023

A little less verbose would be nice

OK, I changed the format to OsmoSDR: airspyhf=0.

@argilo argilo merged commit 154bbe6 into master Oct 6, 2023
20 checks passed
@argilo argilo deleted the sigmf-hw branch October 6, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants