Add core:hw to SigMF metadata files #1305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1182.
As noted in #1182 (comment), it would be useful to store input device metadata in the
core:hw
field, which the SigMF spec defines as:Unfortunately, the gr-osmosdr API does not appear to provide any means to fetch metadata about the device associated with a source block. Metadata about all scanned devices can be retrieved with
osmosdr::device::find()
, but there is no guarantee that the device selected by the device string matches one of the scanned devices. So I think the best we can do for now is write out the current device string, e.g."core:hw": "airspyhf=0"
./cc @Niautanor