Fix the pixels/bin calculation #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcode
approved these changes
Oct 1, 2023
argilo
force-pushed
the
fix-right-pixel
branch
from
78b3712
to
8e285dc
Compare
|
Done. |
|
I think I'd compensated for +/- 1 in a bunch of places. Hopefully, you've simplified it all now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1282.
At many zoom levels, there's an empty pixel at the right hand side of the plot & waterfall displays. As far as I can tell, this happens because the
xScalevariable, which represents the number of pixels per bin, uses the wrong figure (w-1) for the width of the display. (The display is actuallywpixels wide.) As a result, the subsequentxminandxmaxcalculations try to map the bins onto aw-1pixel display, and the rightmost pixel is often left empty (except when rounding error happens to push it one pixel larger). Changing the number of pixels towfixes the problem.