Remove unnecessary clamping checks #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A nice side effect of this change is that A/B marker heads remain visible even when the lines are slightly off-screen. |
|
The diff is easier to review with whitespace changes omitted: https://github.com/gqrx-sdr/gqrx/pull/1285/files?w=1 |
willcode
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clamping was removed from
xFromFreqin #1248. There are a few places in the plotter that explicitly checked for clamping to avoid drawing elements against the edge of the window whenxFromFreqclamped their X coordinate. These checks are no longer necessary, since the clamping is no longer present.In cases where the drawn elements are completely outside the visible area, Qt will simply not draw them.