Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom the plotter faster with Ctrl #1250

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

LevitatingBusinessMan
Copy link
Contributor

Holding control when scrolling will allow you to zoom faster.

@argilo argilo added the feature label Jun 18, 2023
@argilo
Copy link
Member

argilo commented Oct 2, 2023

Thanks for the pull request, and sorry for the long delay in looking at this.

Some changes were made to zooming in #1270, so this code would need to be updated to adjust the 0.9 base value in the new pow calculation.

That said, I'm not sure whether this is a feature that would be used much, particularly since keyboard modifiers to mouse movements are not particularly discoverable. What was your motivation for making this change?

@LevitatingBusinessMan
Copy link
Contributor Author

LevitatingBusinessMan commented Oct 2, 2023

I got tired of having to scroll really aggressively to quickly identify a signal. The zoom speed is fine most of the time but a bit slow when you want to go from seeing the entire band to a tiny signal. At the time I was using some other piece of software that allowed to speed up scrolling by holding a modifier key. It might've been some other SDR software.

Using modifiers with the mouse isn't at all uncommon. Think of 2d and 3d creative software. And even on the webpage you're viewing this on, you can zoom the window using Ctrl and the scrollwheel. And GQRX already has shift and ctrl as modifiers for the waterfall.

I'll update the patch so that you can try it.

As for the discoverability, you could opt to include it in the little info box at the bottom that shows other modifier keys when hovering over the plotter. But the same thing about discoverability could be said about the ctrl and shift modifiers in the waterfall.

In any case, I've been applying this patch whenever I am buildin gqrx, it's quite essential to me.

@argilo
Copy link
Member

argilo commented Oct 2, 2023

I use modifier keys infrequently enough that I had forgotten that Ctrl+wheel adjusts the filter bandwidth when hovering over the plot. I suppose it wouldn't hurt to add Ctrl+wheel functionality to zooming. Do you think the Y axis should be included for consistency?

@argilo
Copy link
Member

argilo commented Oct 6, 2023

I refactored the code slightly, and included both axes. @LevitatingBusinessMan Let me know what you think.

@argilo argilo merged commit 5517fb3 into gqrx-sdr:master Oct 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants