Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iq tool add sampling rate and frequency GUI inputs #1026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vladisslav2011
Copy link
Contributor

This should help to play arbitrary named iq files at correct sampling rate and align waterfall/panadapter to correct center frequency.

@vladisslav2011
Copy link
Contributor Author

Rebased on top of current master.
Fixed 2 issues:
Playback time did not get recalculated when the sampling rate is changed via spinbox.
Both controls were left enabled during playback.

@pinkavaj
Copy link
Contributor

First, thx for the MR. I have taken a look and found few thinks which I hope will help to get it into mater.

20221110_22h43m36s_grim

The numbers in spinboxes have different formating compared to what is already used, eg. LNB LO setting seen on the picture, which is aligned to the right and have the units set as a suffix right in the spin-box it, self.

@vladisslav2011
Copy link
Contributor Author

Thanks.
The 'sample rate' spin box should probably be in sps, like in the 'I/O devices' dialog:
gqrx-input-rate
The 'frequency' spin box format was picked from the 'Receiver options':
gqrx-frequency

Convert the 'Sample rate' to sps or convert both to Msps/MHz?

@pinkavaj
Copy link
Contributor

Good question. My guess is the sps is usually in range xx kHz (sound card input eg 48kHz) to XX MHz (eg. 20 MHz hackRf), 20000 kHz still looks IMHO readable so I would go for ksps.

For frequency I would probably vote for MHz.

The other option to consider might be to replace double spin boxes with integer and enable group separator, then even 1 GHz would make the number still readable (eg 1,000,000,000 in EN 1 000 000 000 in my country) and it would avoid using floats, which might get tricky at some point. So Hz and sps might really work.

@pinkavaj
Copy link
Contributor

Thanks for this, it came in right time because I'm just now looking for a way to play records from another SW..

@vladisslav2011
Copy link
Contributor Author

I have not merged this into my primary dev branch. Usually I just rename/symlink files from other SW to Gqrx-accepted filename format.

@vladisslav2011
Copy link
Contributor Author

The other option to consider might be to replace double spin boxes with integer and enable group separator

I tried this and failed. Integer spinboxes does not allow values larger, than 1000000000...

@pinkavaj
Copy link
Contributor

The other option to consider might be to replace double spin boxes with integer and enable group separator

I tried this and failed. Integer spinboxes does not allow values larger, than 1000000000...

Yep, having the 'sample rate' spin box the same as in 'I/O devices' dialog makes sense to me too.

The unit still should be moved from label into the spinbox suffix, at least this is main blocker IMHO.

@argilo argilo added the feature label Mar 25, 2023
…yback arbitrary named files correctly

Recalcute playback time on sampling rate change.
Disable inputs during playback/recording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants