ci: added mypy to precommit #1070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 26 26
Lines 1393 1393
=======================================
Hits 1172 1172
Misses 221 221 ☔ View full report in Codecov by Sentry. |
|
Good initiative! Wouldn't this be a nice project for automatic type fixing? Someone could set up a self-heal with gpt-engineer which for example fixes types file by file and runs until mypy passes. |
|
@ATheorell Yes! I think we should be able to make a general self-heal that supports any linter/checker. |
Israel-Laguan
approved these changes
May 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to get #1057 merged I noticed there were a bunch of type errors that were only caught in tests. I thought we had some kind of typechecking on the codebase, but apparently not.
I added mypy to the precommit config, but it found 100+ type errors.
Here's the PR anyway, as a reminder we might want to get around to cleaning up the types.