Locale passed in as parameter in args is now taken into account when rendering. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm rendering PDF in an event listener (platform-core) and it uses the default locale. I want it to render with a fixed locale. Is this pull request the only way to set locale or is there a current way of doing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XhtmlDocumentService never allowed the locale in the request used by RenderEnvironment to be overridden with a custom locale. This patch will enable to Locale to be used for rendering to be overridden by the locale argument.
The test in PdfRenderingServiceSpec feels clunky, any suggestions on making it better are welcome.