-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiki updates #15
Open
PierreDillard
wants to merge
30
commits into
gpac:master
Choose a base branch
from
PierreDillard:wiki-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wiki updates #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer near dark mode icon
- Relocated the Table of Contents (TOC) to the right side of the UI - Added a settings icon to the interface - Implemented a dropdown menu with options to configure settings: - Collapse TOC - Adjust TOC levels - Toggle dark mode
Hey @nlsdvl, I hope you're doing well! When you have a moment, could you please review the updates in this PR? I've restored the Table of Contents, adjusted the menu settings, and added a few customization options. Any feedback would be greatly appreciated ! |
- Resolved issues with the collapse icons on the left sidebar. - Improved the navigation behavior related to icon collapsing.
- Changed the modal behavior to trigger on mouse hover rather than on click.
- Moved the modal to the left of the screen. - Adjusted the modal to be horizontally centered as well.
- Wrap logic in try...catch blocks to handle unexpected errors
- Modal now opens just above the keywords - Filters display dynamically based on the level - Added linear gradient to the modal and collapsible elements - Added Command operations section to the mkdocs.yml file
when merging this, we'll have to merge https://github.com/gpac/gpac/tree/buildbot-hintclass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to Feedback
Thank you for your detailed feedback.
Glossary tab / Keywords Cloud
The glossary tab doesn't show up in expert mode, is that expected?
Dark mode styling missing
Is this compatible with tags?
Back to top
Beginner / Expert mode
Motivation for this change
Expert mode switch location
Content tagging and related switch
Bug on /Filters/avmix page
Search feature issue
Collapsible content
Dark mode styling
Default collapsed state
Spacing issue
Safari desktop issue
Switch (TOC/NAV) on the left
Reason for change
User understanding
Git related feedback