Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom headers to be sent through http requests #180

Merged
merged 2 commits into from
Oct 6, 2023
Merged

feat: allow custom headers to be sent through http requests #180

merged 2 commits into from
Oct 6, 2023

Conversation

tanguyantoine
Copy link
Contributor

@tanguyantoine tanguyantoine commented Oct 4, 2023 •
edited
Loading

What

  • add new options to CLI: extra_http_headers

Why

  • it allows to provide extra headers to requests sent to Metabase instance

Use case

it allows instances to be reached when they are deployed behind security system (ex https://developers.cloudflare.com/cloudflare-one/identity/service-tokens/#connect-your-service-to-access)

example

dbt-metabase models --http_extra_headers CF-Access-Client-Id $CF_CLIENT_ID --http_extra_headers CF-Access-Client-Secret $CF_CLIENT_SECRET

thanks to @elongl and @elementary-data for the initial implementation

elementary-data@91c3465

@tanguyantoine
Copy link
Contributor Author

@gouline I have run black to format the files correctly

@gouline
Copy link
Owner

gouline commented Oct 4, 2023

To save time, run all the checks locally prior to pushing commits.

@tanguyantoine
Copy link
Contributor Author

@gouline sorry for that, I have run make check and it is working now :-)

gouline
gouline requested changes Oct 5, 2023
View reviewed changes
dbtmetabase/__init__.py Outdated Show resolved Hide resolved
@gouline gouline merged commit 297ab1f into gouline:master Oct 6, 2023
1 check passed
@tanguyantoine tanguyantoine deleted the feat/allow-custom-headers branch October 7, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouline gouline gouline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanguyantoine @gouline