Exposure updated format #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elongl
commented
Sep 1, 2023
| for exposure in list({m for m in self.models_exposed}) | ||
| if exposure.upper() in refable_models | ||
| ], | ||
| "depends_on": list( |
There was a problem hiding this comment.
Deduping in case a dashboard has two views on the same table.
gouline
requested changes
Sep 4, 2023
| @@ -645,7 +645,6 @@ def increase_indent(self, flow=False, indentless=False): | |||
| parsed_exposures = [] | |||
|
|
|||
| for collection in self.collections: | |||
|
|
|||
Merged
gouline
added a commit
that referenced
this pull request
Oct 6, 2023
* Exposure updated format (#175) * Changed exposure format (lowercased name, deduped depends_on). * Change where the lowercasing happens. * Hyphens are no longer allowed. * Updated comment. * Revert useless formatting * Set comprehension for deduping * Lowercase all exposure names in tests --------- Co-authored-by: Elon Gliksberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.