Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use updated validate plugin #79

Merged
merged 2 commits into from
Sep 23, 2023
Merged

build: use updated validate plugin #79

merged 2 commits into from
Sep 23, 2023

Conversation

bsushmith
Copy link
Collaborator 

(⎈|minikube)➜  guardian git:(fix-buf-generate) cat buf.gen.yaml 
version: v1
plugins:
  - plugin: buf.build/protocolbuffers/go:v1.28.1
    out: api/proto
    opt: paths=source_relative
  - plugin: buf.build/grpc/go:v1.2.0
    out: api/proto
    opt:
      - paths=source_relative
      - require_unimplemented_servers=true
  - plugin: buf.build/grpc-ecosystem/gateway:v2.15.1
    out: api/proto
    opt: paths=source_relative
  - plugin: buf.build/grpc-ecosystem/openapiv2:v2.15.1
    out: third_party/OpenAPI
  - plugin: buf.build/bufbuild/validate-go:v1.0.2
    out: api/proto
    opt:
      - paths=source_relative
(⎈|minikube)➜  guardian git:(fix-buf-generate) buf --version
1.26.1
(⎈|minikube)➜  guardian git:(fix-buf-generate) make proto
Generating protobuf from goto/proton
 [info] make sure correct version of dependencies are installed using 'make install'
Protobuf compilation finished
(⎈|minikube)➜  guardian git:(fix-buf-generate)

@bsushmith bsushmith linked an issue Sep 22, 2023 that may be closed by this pull request
make proto is failing in this repo, some issue in buf plugins #78
Closed
rahmatrhd
rahmatrhd approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@rahmatrhd rahmatrhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works testing this in my local

@bsushmith bsushmith merged commit b2ee1e8 into main Sep 23, 2023
6 checks passed
@bsushmith bsushmith deleted the fix-buf-generate branch September 23, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make proto is failing in this repo, some issue in buf plugins
2 participants
@bsushmith @rahmatrhd