fix: fix bug in list grants with resource filters #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add filter q, account_type for litAppeals and listGrants and added getTotalCount * chore: added testing for total count * chore: fix testing * chore: fix test total * chore: fix test mock appeal and grant * chore: fix test mock user appeal and grant * chore: fix test coverage * chore: fix test coverage 2 * chore: fix test coverage 3 * chore: resolve comments * test: resolve comments * test: fix testing --------- Co-authored-by: Lifosmin Simon <[email protected]>
* feat: introduce new resource type "service_account" in gcloud_iam provider * feat: grant and revoke access to service account * test: add test cases for service account provider * refactor: use switch case * chore: user goreleaser v1.18.2 * chore: use goreleaser v1.8.3 * chore: fix release pipeline * fix: fix fetching grantable roles next page token * refactor: remove additional checking * chore: use email as service account resource name * test: add more unit tests for GetResources * test: add more unit tests for Grant and Revoke Access
feat(gcloud_iam): manage service account access (goto#58)
rahmatrhd
changed the title
rahmatrhd
reviewed
Sep 5, 2023
rahmatrhd
requested changes
Sep 5, 2023
lifosmin
commented
Sep 5, 2023
rahmatrhd
approved these changes
Sep 7, 2023
rahmatrhd
added a commit
that referenced
this pull request
Sep 14, 2023
* bug: grant resource doenst get query * bug: grant resource doenst get query * test: grant resource 1 * test: grant resource 2 * Update grant_repository_test.go --------- Co-authored-by: Lifosmin Simon <[email protected]> Co-authored-by: Rahmat Hidayat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.